Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UDP/TCP Bind #39

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

UDP/TCP Bind #39

wants to merge 7 commits into from

Conversation

alonbg
Copy link

@alonbg alonbg commented Sep 12, 2016

+tests

@alonbg
Copy link
Author

alonbg commented Sep 14, 2016

Hi @agentzh
Some tests keep failing although all tests pass on my local.
Please advise (maybe on a better way to write them :). Thanks!

@bjne
Copy link

bjne commented Oct 25, 2016

What is the status here? Nice effort, but code does not build.

@alonbg
Copy link
Author

alonbg commented Nov 1, 2016

@agentzh you suggested having ip_transparent in the setoption api. I'm really not sure this is the way to go since there is a dependency between ip_transparent and bind. As in proxy_bind address [transparent] | off; directive which sets sets pc-local which in turn is a condition for checking pc->transparent value. In other words, binding to a local address is a mandatory condition for setting the ip_transparent socket option.
Maybe also in our case transparent should be a bind() option instead of a separate api.
What do you think ?

@splitice
Copy link

splitice commented Nov 1, 2016

I tend to agree with @alonbg, its closer to the nginx semantics too which is appealing to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants